Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Runner uploads last line of script output as error message if script … #63

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Runner uploads last line of script output as error message if script … #63

merged 1 commit into from
Dec 18, 2024

Conversation

lkeegan
Copy link
Member

@lkeegan lkeegan commented Dec 18, 2024

…fails

  • runner
    • capture and display stdout while script is running
    • upload last line of output as the error_message if script return code is non-zero
  • backend
    • add error_message to Sample model
    • store the uploaded error message from the runner here (was already stored in the job, but not the sample)
  • frontend
    • display error_message in Samples table
  • resolves Provide error message if script fails #54

@lkeegan
Runner uploads last line of script output as error message if script …
c9a63b0 
…fails

- runner
  - capture and display stdout while script is running
  - upload last line of output as the error_message if script return code is non-zero
- backend
  - add `error_message` to Sample model
  - store the uploaded error message from the runner here (was already stored in the job, but not the sample)
- frontend
  - display `error_message` in Samples table
- resolves #54
@lkeegan lkeegan merged commit 4ca7c34 into main Dec 18, 2024
5 checks passed
@lkeegan lkeegan deleted the runner_use_last_line_of_failed_script_as_error_message branch December 18, 2024 10:32
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.10%. Comparing base (0a8ad33) to head (c9a63b0).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #63      +/-   ##
==========================================
+ Coverage   77.98%   78.10%   +0.12%     
==========================================
  Files           8        8              
  Lines         713      717       +4     
==========================================
+ Hits          556      560       +4     
  Misses        157      157

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide error message if script fails
2 participants
@lkeegan @codecov-commenter